Remove unitless line height #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jacobp100 merged 1 commit into master from remove-unitless-lineheight

Oct 4, 2019

Contributor

jacobp100 commented Oct 3, 2019

Since we're doing a major release anyway, I want to remove this, as it does the wrong thing in the following case,

const Component = styled(View)`
  font: 16px/1.5 system;
`

const IncorrectLineHeight = () => (
  <Component style={{ fontSize: 24 }} />
)


          Remove unitless line height

734136a

jacobp100 requested a review from kristerkari

October 3, 2019 20:15

kristerkari approved these changes

View reviewed changes

Contributor

kristerkari left a comment

Looks good :)

jacobp100 merged commit 26f4b49 into master

jacobp100 deleted the remove-unitless-lineheight branch

October 4, 2019 07:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet